Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upalign C ported memsearch code - need to handle array[length] properly #5037
+26
−7
Conversation
kares
added this to the JRuby 9.1.16.0 milestone
Feb 8, 2018
| } | ||
| else { | ||
| h = '\0'; // (C) ary end - due y+m at rb_memsearch_qs_utf8 | ||
| } | ||
| if (h < 0xC0) { | ||
| return h + 256; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kares
Feb 13, 2018
Member
yep - should return the very same as the (original) C code when reaching \0 boundary
headius
referenced this pull request
Feb 13, 2018
Closed
Scan ArrayIndexOutOfBoundsException Error #5036
kares
merged commit 23f53d3
into
jruby-9.1
Feb 14, 2018
kares
deleted the
fix-2036-9.1
branch
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kares commentedFeb 8, 2018
•
edited
... otherwise code doing utf8 str scan might fail with array-out-of-index
resolves GH-5036
someone with C knowledge please review, seems to me that MRI handles the case without special care :
at
rb_memsearch_qs_utf8_hash(byte[] xBytes, final int x)whilex == xBytes.length