Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FrozenError class #5039

Merged
merged 2 commits into from Feb 12, 2018
Merged

Add FrozenError class #5039

merged 2 commits into from Feb 12, 2018

Conversation

@nomadium
Copy link
Contributor

@nomadium nomadium commented Feb 12, 2018

Hi folks,

This is another feature targeting Ruby 2.5 [1]:

  • Add FrozenError as a subclass of RuntimeError (feature #13224).

FrozenError will be used instead of RuntimeError for exceptions
raised when there is an attempt to modify a frozen object.

For more information, please see feature #13224

Note: The updated tests are copied from MRI.

Thanks for your review and feedback.

  1. #4876
nomadium added 2 commits Feb 12, 2018
FrozenError will be used instead of RuntimeError for exceptions
raised when there is an attempt to modify a frozen object. The
reason for this change is to differentiate exceptions related
to frozen objects from generic exceptions such as those generated
by Kernel#raise without an exception class.

For more information, please see feature #13224.
@enebo enebo added this to the JRuby 9.3.0.0 milestone Feb 12, 2018
@enebo enebo merged commit 9b5753f into jruby:ruby-2.5 Feb 12, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@nomadium nomadium deleted the nomadium:add-frozen-error-class branch Feb 13, 2018
@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants