Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module#attr, attr_accessor, attr_reader, attr_writer are now public #5043

merged 2 commits into from Feb 15, 2018


Copy link

@nomadium nomadium commented Feb 14, 2018

Hi folks,

This is another feature targeting Ruby 2.5 [1]:

  • Module#attr, attr_accessor, attr_reader, attr_writer are now public (feature #14132).

Note: The tests are copied from MRI.

Thanks for your review and feedback.

  1. #4876
nomadium added 2 commits Feb 14, 2018
New public methods on Module class:

  - attr
  - attr_accessor
  - attr_reader
  - attr_writer
For more information, please see feature #14132.
@enebo enebo added this to the JRuby milestone Feb 15, 2018
@enebo enebo merged commit 7901f47 into jruby:ruby-2.5 Feb 15, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
@nomadium nomadium deleted the nomadium:module-attr-methods-are-now-public branch Feb 15, 2018
@enebo enebo modified the milestones: JRuby, JRuby Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants