New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mathn.rb from stdlib #5051

Closed
wants to merge 1 commit into
base: ruby-2.5
from

Conversation

Projects
None yet
3 participants
@nomadium
Contributor

nomadium commented Feb 16, 2018

Hi folks,

This is another change targeting Ruby 2.5 [1]: Remove mathn from stdlib (feature #10169).

Thanks for your review and feedback.

  1. #4876
Remove mathn.rb from stdlib
For more information, please see feature #10169.
@enebo

This comment has been minimized.

Member

enebo commented Feb 16, 2018

@nomadium Your previous changes to test/mri were ok because they reflected copies from MRI's test in their repo. When we resync those tests it ends up being zero sum since your submissions and those tests are identical.

For ruby/spec (e.g. ruby/spec/ruby) they did not actually remove these files right? If anything they probably changed inclusive range from ..."2.5" to .."2.5". I am pretty sure those should not be touched. Perhaps we do need to update them to latest from ruby/spec though?

@headius

This comment has been minimized.

Member

headius commented Feb 17, 2018

I updaged stdlib from 2.5 yesterday, which included removing mathn.rb. Thanks for your help!

@headius headius closed this Feb 17, 2018

@headius headius added this to the JRuby 9.2.0.0 milestone Feb 17, 2018

@nomadium nomadium deleted the nomadium:remove-mathn-from-stdlib branch Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment