New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jffi and release version for JRuby 1.7 #5072

Closed
wants to merge 2 commits into
base: jruby-1_7
from

Conversation

Projects
None yet
2 participants
@DJRickyB

DJRickyB commented Mar 1, 2018

prevents SEGFAULTs described in #4506

I understand the intent is not to update 1.7 anymore, but this change is being tested at our organization currently and could save us a lot of grief

rick.boyd added some commits Mar 1, 2018

rick.boyd
rick.boyd
@headius

This comment has been minimized.

Member

headius commented Apr 12, 2018

Sorry for the delay in looking at this. Unfortunately we do not have plans or resources to do a 1.7.28 release. I'll ping @enebo here and we can discuss a path forward. Is there no way for you to update to a JRuby 9.x version?

@headius headius added this to the JRuby 9.1.17.0 milestone Apr 12, 2018

@headius

This comment has been minimized.

Member

headius commented Apr 12, 2018

Oops, I marked this for 9.1.17 without realizing 9.1 has already been bumped up to jffi 1.2.16.

@DJRickyB

This comment has been minimized.

DJRickyB commented Apr 12, 2018

Actually we were still getting segfaults even after this patch. I see the initial issue has some recent activity. We are going to be pushing our devs to convert legacy projects to 9k for sure

@DJRickyB DJRickyB closed this Apr 12, 2018

@headius

This comment has been minimized.

Member

headius commented Apr 12, 2018

@DJRickyB Yes, in #4506 there's discussion about how to fix this better in jnr-ffi, but so far no patch from the contributor. It would likely require a rebuild of the native bits of jffi, which means there's a bit of a long tail in getting it released (we support some obscure platforms that would need rebuilds). But there's a solution out there.

Can you describe your application and how you're running it? There are some workarounds that may help.

@DJRickyB

This comment has been minimized.

DJRickyB commented Apr 12, 2018

we have multiple rails apps co-existing on tomcat using (now) a patched version of JRuby 1.7 with the change in this PR. Each is in a separate warbler-generated war running via jruby-rack.

Sporadic segfaults have been traced back to JFFI and match #4506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment