New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fetch for Thread.current #5089

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
3 participants
@ChrisBr
Contributor

ChrisBr commented Mar 16, 2018

https://bugs.ruby-lang.org/issues/13009
#4876

Tests are already implemented in ``test/mri/ruby/test_thread.rb#test_thread_local_fetch"

@headius headius added this to the JRuby 9.2.0.0 milestone Mar 16, 2018

@headius headius merged commit 2f3f533 into jruby:ruby-2.5 Mar 16, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@headius

This comment has been minimized.

Member

headius commented Mar 16, 2018

🎉

@headius headius referenced this pull request Mar 16, 2018

Closed

Ruby 2.5 Support #4876

64 of 75 tasks complete

@nomadium nomadium referenced this pull request Mar 17, 2018

Closed

Implement Thread#fetch #5034

@nomadium

This comment has been minimized.

Contributor

nomadium commented Mar 17, 2018

Good to see progress with more Ruby 2.5 features in JRuby although I was wondering why this PR superseded #5034 since it was almost the same change.

@ChrisBr

This comment has been minimized.

Contributor

ChrisBr commented Mar 17, 2018

@nomadium oh sorry, I missed this PR 😢

@nomadium

This comment has been minimized.

Contributor

nomadium commented Mar 17, 2018

@ChrisBr No worries, I guess it was not hard to miss since there are a fair amount of open PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment