New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Complex#finite? and Complex#infinite? failing tests #5101

Merged
merged 2 commits into from Mar 21, 2018

Conversation

Projects
None yet
2 participants
@ChrisBr
Contributor

ChrisBr commented Mar 21, 2018

test/mri/ruby/test_complex.rb#test_infinite_p and test/mri/ruby/test_complex.rb#test_infinite_p were failing.

See in MRI
ruby/ruby@65d7479
ruby/ruby@241ba38

ChrisBr added some commits Mar 21, 2018

Fix Complex#finite?
to use real and image value instead of the magnitude to check for finite.
See ruby/ruby@241ba38 in MRI.
Fix Complex#infinite?
and use real and imagine values instead of magnitude to check for infinite.
See ruby/ruby@65d7479 in MRI.

@headius headius merged commit 21f0aa0 into jruby:ruby-2.5 Mar 21, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@headius headius added this to the JRuby 9.2.0.0 milestone Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment