Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RubyString instances to raise FrozenError exceptions when mutations are attempted in debug mode… #5106


Copy link

@nomadium nomadium commented Mar 23, 2018

String instances were raising FrozenError exceptions as expected since Ruby 2.5, when modifications on frozen instances are attempted but the same was not happening in debug mode (they were raising RuntimeError, the expected behavior until 2.4).

This should fix a lot of failures in ruby-2.5 branch.

/cc: #4876

…ns are attempted in debug mode

It was working OK in normal mode but not in debug mode.
@enebo enebo added this to the JRuby milestone Mar 23, 2018
@enebo enebo merged commit 5799d96 into jruby:ruby-2.5 Mar 23, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
@nomadium nomadium deleted the nomadium:fix-string-tests-with-frozen-error-related-failures branch Mar 24, 2018
@enebo enebo modified the milestones: JRuby, JRuby Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.