Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix RubyString instances to raise FrozenError exceptions when mutations are attempted in debug mode… #5106
Conversation
enebo
added this to the JRuby 9.3.0.0 milestone
Mar 23, 2018
enebo
merged commit 5799d96
into
jruby:ruby-2.5
Mar 23, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
nomadium
deleted the
nomadium:fix-string-tests-with-frozen-error-related-failures
branch
Mar 24, 2018
enebo
modified the milestones:
JRuby 9.3.0.0,
JRuby 9.2.0.0
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nomadium commentedMar 23, 2018
String instances were raising FrozenError exceptions as expected since Ruby 2.5, when modifications on frozen instances are attempted but the same was not happening in debug mode (they were raising RuntimeError, the expected behavior until 2.4).
This should fix a lot of failures in ruby-2.5 branch.
/cc: #4876