Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed Ruby 2.5 ruby/spec tests for String #5107



Copy link

@nomadium nomadium commented Mar 25, 2018

Hi folks,

This PR should fix most of the remaining failures for String in ruby-2.5 ruby/spec suite.

Thanks for your review and feedback.

/cc: #4876

nomadium added 5 commits Mar 25, 2018
…at string since Ruby 2.5
@kares kares added this to the JRuby milestone Mar 26, 2018
@kares kares merged commit 20cada4 into jruby:ruby-2.5 Mar 26, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
@nomadium nomadium deleted the nomadium:fix-ruby-2.5-ruby-spec-tests-for-string branch Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.