Fix failed Ruby 2.5 ruby/spec tests for String #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at string since Ruby 2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi folks,
This PR should fix most of the remaining failures for String in ruby-2.5 ruby/spec suite.
2e1987d and 77cc454 fix failed assertions like
jruby/spec/ruby/core/string/delete_prefix_spec.rb
Line 15 in f06aa9d
113bde3 and 617e783 fix failed assertions like
jruby/spec/ruby/core/string/delete_suffix_spec.rb
Line 77 in f06aa9d
49a74b9 fix failed assertions like
jruby/spec/ruby/core/string/modulo_spec.rb
Line 31 in f06aa9d
Thanks for your review and feedback.
/cc: #4876