New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread.report_on_exception default value is now true #5108

Merged
merged 1 commit into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@nomadium
Contributor

nomadium commented Mar 25, 2018

Hi folks,

This is another change targeting Ruby 2.5 [1]: Thread.report_on_exception default value is now true (feature 14143).

Thanks for your review and feedback.

  1. #4876
  2. https://bugs.ruby-lang.org/issues/14143
Thread.report_on_exception is now true by default
Unhandled exceptions terminating threads are shown on $stderr.

For more information, please see feature #14143.
@kares

This comment has been minimized.

Member

kares commented Mar 26, 2018

are you sure about the warning message format? seems they agreed on smt different on the tracker ...

@nomadium

This comment has been minimized.

Contributor

nomadium commented Mar 26, 2018

@kares That's the message that I observed when tested MRI and also I read it in their source code. Please see below:

@enebo enebo added this to the JRuby 9.3.0.0 milestone Mar 26, 2018

@enebo enebo merged commit 841ae3c into jruby:ruby-2.5 Mar 26, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@nomadium nomadium deleted the nomadium:thread-report-on-exception-default-value-is-now-true branch Mar 27, 2018

@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment