Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Require real path #5121
expand load paths to real paths to get rid of duplicate loading from
Deletes obsolete spec/regression/GH-1940_symlink_load_path_should_not_expand_in_FILE_spec.rb
Apr 18, 2018
1 check failed
Grr...it's still failing. Herre's the error I see...it's a symlinked jar file that should be loaded as a jar file, but because of traversing the link it tries to load as a Ruby file.
[exec] Java::OrgJrubyEmbed::EvalFailedException: (SyntaxError) /home/travis/build/jruby/jruby/test/jruby/jarwithoutextension:1: Invalid char `\3' ('�') in expression [exec] PK�;c�7 �META-INF/���PK�PK�;c�7�META-INF/MANIFEST.MF�M��LK-.� [exec] K-*��ϳR0�3��r.JM,IM�u�� ������+h8���*8��������(x�%�i�r�r�PK�%�tFFPK�/c�7�hello_from_jar.rbS�H���W�UP��T��PK�m!���PK��org.jruby.embed.internal.EmbedEvalUnitImpl.run(org/jruby/embed/internal/EmbedEvalUnitImpl.java:131) [exec] org.jruby.embed.ScriptingContainer.runUnit(org/jruby/embed/ScriptingContainer.java:1295) [exec] org.jruby.embed.ScriptingContainer.runScriptlet(org/jruby/embed/ScriptingContainer.java:1288)
It is from the JRuby-specific test suite, so maybe it's possible that this is not correct behavior?
I believe the issue is that, while it's fine to traverse the link for the file contents, it should still make its decision about what kind of file it is based on the first found filename...maybe?
I'm going to let you try to fix it. You can run the one test with