/ jruby Public
Handle exception cause with null message #5146
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
The handling of exc exceptions in the jsr223 JRubyEngine assumes that all exceptions have causes, and that the cause has a non-null message. This is not always the case and results in a NullPointerException without the original exception.
I added a test for the two cases I know of.
I noticed that all the other tests for the jsr223 JRubyEngine are disabled. Any reason for that?