Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle exception cause with null message #5146
Conversation
donv
self-assigned this
Apr 23, 2018
donv
requested review from
headius and
enebo
Apr 23, 2018
kares
merged commit d83d15b
into
master
Apr 25, 2018
kares
deleted the
handle_exception_cause_with_null_message
branch
Apr 25, 2018
kares
added this to the JRuby 9.2.0.0 milestone
Apr 25, 2018
added a commit
that referenced
this pull request
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
donv commentedApr 23, 2018
The handling of exc exceptions in the jsr223 JRubyEngine assumes that all exceptions have causes, and that the cause has a non-null message. This is not always the case and results in a NullPointerException without the original exception.
I added a test for the two cases I know of.
I noticed that all the other tests for the jsr223 JRubyEngine are disabled. Any reason for that?