New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception cause with null message #5146

Merged
merged 1 commit into from Apr 25, 2018

Conversation

Projects
None yet
2 participants
@donv
Member

donv commented Apr 23, 2018

The handling of exc exceptions in the jsr223 JRubyEngine assumes that all exceptions have causes, and that the cause has a non-null message. This is not always the case and results in a NullPointerException without the original exception.

I added a test for the two cases I know of.

I noticed that all the other tests for the jsr223 JRubyEngine are disabled. Any reason for that?

@donv donv self-assigned this Apr 23, 2018

@donv donv requested review from headius and enebo Apr 23, 2018

@kares kares merged commit d83d15b into master Apr 25, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@kares kares deleted the handle_exception_cause_with_null_message branch Apr 25, 2018

@kares kares added this to the JRuby 9.2.0.0 milestone Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment