Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hack for FileUtils.mv due to incorrect error raised from File.rename #5168

Merged
merged 3 commits into from May 13, 2018

Conversation

Projects
None yet
1 participant
@headius
Copy link
Member

headius commented May 13, 2018

In MRI, File.rename will raise an EXDEV if the rename is attempted with paths that span devices (mounts). Up until this PR, we would raise EACCES in such a situation, requiring us to modify fileutils.rb to deal with both errors.

Because this is tweaking a very core behavior of File and FileUtils, I'm pushing to a branch to see how it affects our test runs.

This fix is an attempt to deal with at least part of Bundler's vendoring of a non-JRuby fileutils.rb. See bundler/bundler#6532.

headius added some commits May 13, 2018

Raise EXDEV when attempting to rename across devices.
This fix is needed because Bundler now vendors an MRI version of
fileutils that does not include our hacks for the incorrect EACCES
error. That is a larger issue since there's other hacks we have
not eliminated, but this fixes a primary issue bundling libraries.

@headius headius added this to the JRuby 9.2.0.0 milestone May 13, 2018

@headius headius merged commit be4a079 into master May 13, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@headius headius deleted the fu_mv_exdev branch May 13, 2018

headius added a commit to jruby/ruby that referenced this pull request May 13, 2018

headius added a commit to jruby/ruby that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.