New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate jruby/core_ext Class#subclasses #5181

Merged
merged 4 commits into from May 23, 2018

Conversation

Projects
None yet
2 participants
@kares
Member

kares commented May 21, 2018

has been discussed at: #4741 ... non clashing replacement: JRuby.subclasses_of(klass, all: false)

@kares kares added this to the JRuby 9.2.0.0 milestone May 21, 2018

@kares kares requested a review from headius May 21, 2018

@headius

This all looks fine, but for some reason the name bothers me 😁

@kares

This comment has been minimized.

Member

kares commented May 23, 2018

@headius yeah wasn't sure ... than wasn't sure about JRuby.subclasses(klass, all: false) either
... but I'm fine with it if it sounds better for you - my EN isn't native so I might not pick the best :)

@kares kares merged commit f574f9d into master May 23, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@kares kares deleted the deprecate-subclasses branch May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment