Generate new empty RubyString's with US-ASCII encoding. #522

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@BanzaiMan
Member

Based on search shown in https://gist.github.com/4698031

@enebo enebo was assigned Feb 2, 2013
@enebo
Member
enebo commented Feb 19, 2013

I just reviewed the regexp newstring changes and I think you might need to audit these individually. One of the two changes is for 1.8 mode which I think newString() is correct for that. The second was for union19 which arguably is correct except that the method will unconditionally set the encoding on the string. So in that case one could argue the change is not needed.

@enebo
Member
enebo commented Feb 26, 2013

After talking to Hiro we decided to close this and fix per reported case if there are any.

@enebo enebo closed this Feb 26, 2013
@headius headius deleted the new_empty_string_in_us_ascii branch Nov 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment