Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Complimentary Regression Test for GH-5203 #5265

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@aryeh-looker
Copy link
Contributor

aryeh-looker commented Jul 29, 2018

The regression test in b087544 is very good. Unlike the regression test in b087544, however, the AWS S3 SDK receives a string via a regex and encounters the same bug.

The regression test in this PR mimics the S3 SDK by receiving a string from a regex match and asserts that the string is not mutated via StringIO manipulation.

This regression test fails without b087544 , but succeeds with that fix.

Related to #5203 (comment). cc/ @kares

@aryeh-looker aryeh-looker changed the title Add Another Regresion Test for GH-5203 Add Complimentary Regression Test for GH-5203 Jul 29, 2018

@enebo enebo added this to the JRuby 9.2.1.0 milestone Sep 19, 2018

@enebo enebo merged commit 4f75b6c into jruby:master Sep 19, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@aryeh-looker aryeh-looker deleted the aryeh-looker:aryeh/add-regression-test-gh-5203 branch Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.