Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some failed tests for Enumerable#all?, #any?, #none? and #one? #5296

Merged

Conversation

@nomadium
Copy link
Contributor

@nomadium nomadium commented Aug 29, 2018

Hi folks,

I noticed that some tests related to a feature that I introduced months ago were tagged as failing so I gave a shot to fix them.

Those tests should be passing now.

As usual, any feedback is more than welcome.

Fix use case with a block yields multiple arguments when each yields multiple
@enebo enebo added this to the JRuby 9.2.1.0 milestone Aug 29, 2018
@kares
Copy link
Member

@kares kares commented Sep 3, 2018

along with 5572b29 should be good to go. any reason it wasn't merged @enebo ?

@enebo enebo merged commit 5ada2aa into jruby:master Sep 3, 2018
1 check passed
@nomadium nomadium deleted the fix-enumerable-all-any-none-one-failed-tests branch Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants