Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some failed Enumerable#find_index specs #5303

Merged

Conversation

@nomadium
Copy link
Contributor

@nomadium nomadium commented Aug 31, 2018

Hi folks,

This change should fix the remaining failing specs for Enumerable#find_index.

This change removes the assumption that #each would yield passing always a single object. It could yield without passing parameters, passing one or more objects or yield an explicit array (empty or not).

This change removes the assumption that #each would yield passing always
a single object. It could yield without passing parameters, passing one
or more objects or yield an explicit array (empty or not).
@kares kares merged commit 5572b29 into jruby:master Sep 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kares kares added this to the JRuby 9.2.1.0 milestone Sep 3, 2018
@kares
Copy link
Member

@kares kares commented Sep 3, 2018

nice find!

@nomadium nomadium deleted the nomadium:fix-enumerable-find-index-failed-tests branch Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants