Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate method on NilClass should raise TypeError #5317



Copy link

@nomadium nomadium commented Sep 19, 2018

I noticed an small difference between MRI and JRuby specs. According to them, to try to allocate space for a new instance of NilClass should raise a TypeError instead of returning nil.

@enebo enebo added this to the JRuby milestone Sep 19, 2018
@enebo enebo merged commit 7ea2895 into jruby:master Sep 19, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Copy link

@enebo enebo commented Sep 19, 2018

OPTIMISM at it's sure of this one I did not let travis complete...thanks for the PR!

@nomadium nomadium deleted the nomadium:nilclass-allocate-should-raise-typeerror branch Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants