Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tagged as failed spec for Enumerable#slice_when #5323

Conversation

@nomadium
Copy link
Contributor

@nomadium nomadium commented Sep 24, 2018

In order to iterate correctly over Enumerable elements, #each_entry method should be used, because that method will convert multiple values from yield to an array, if required.

This is a fix similar to #5302.

In order to iterate correctly over Enumerable elements, #each_entry
method should be used, because that method will convert multiple
values from yield to an array, if required.
@nomadium
Copy link
Contributor Author

@nomadium nomadium commented Sep 24, 2018

@kares kares merged commit dbdb80f into jruby:master Sep 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kares kares added this to the JRuby 9.2.1.0 milestone Sep 25, 2018
@nomadium nomadium deleted the nomadium:fix-tagged-spec-enumerable-slice_when-an-iterator-yields-more-than-one-value branch Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants