Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mvnw jar file path for Cygwin #5335

Merged
merged 1 commit into from Oct 1, 2018

Conversation

@fenrir-naru
Copy link
Contributor

@fenrir-naru fenrir-naru commented Sep 29, 2018

mvnw failed under Cygwin with Windows JDK with the following error message.
Error: Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain
This is because maven-wrapper.jar could not be found, and this PR fixes it.

mvnw failed under Cygwin with Windows JDK, because maven-wrapper.jar could not be found.
@mkristian
Copy link
Member

@mkristian mkristian commented Oct 1, 2018

:+1 for merging this. but there is a possibility that we are going to overwrite this accidentally in the future, as this file comes from: https://github.com/takari/maven-wrapper

@fenrir-naru
Copy link
Contributor Author

@fenrir-naru fenrir-naru commented Oct 1, 2018

@mkristian Thank you for your comment. I checked, and this PR seems to be a subset of takari/maven-wrapper#83 . I hope this PR will be closed when the upstream PR is merged.

@mkristian mkristian merged commit df64fb7 into jruby:master Oct 1, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@kares kares added this to the JRuby 9.2.1.0 milestone Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants