Fix mvnw jar file path for Cygwin #5335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvnw failed under Cygwin with Windows JDK, because maven-wrapper.jar could not be found.
|
:+1 for merging this. but there is a possibility that we are going to overwrite this accidentally in the future, as this file comes from: https://github.com/takari/maven-wrapper |
|
@mkristian Thank you for your comment. I checked, and this PR seems to be a subset of takari/maven-wrapper#83 . I hope this PR will be closed when the upstream PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvnw failed under Cygwin with Windows JDK with the following error message.
Error: Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain
This is because maven-wrapper.jar could not be found, and this PR fixes it.