Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enumerable#find_each block arity #534

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@sluukkonen
Copy link
Contributor

commented Feb 13, 2013

Should fix #525.

@sluukkonen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2013

Ahh, I forgot that the specs will be run in 1.8 mode as well. Sorry, I should've caught that earlier, but for some reason, the extended test suite fails on my machine (even on master, which seems to be passing on Travis), so I couldn't run it before submitting this.

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Feb 15, 2013

I feel that the spec should go to RubySpec.

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Feb 15, 2013

I cherry-picked sluukkonen/jruby@b38990d to the master as de1abd0.

@enebo

This comment has been minimized.

Copy link
Member

commented Feb 19, 2013

I am closing for accounting that this was fixed for 1.7.3. We would still love for you to submit this fixed behavior as a spec to the rubyspec project (pretty please) :)

@enebo enebo closed this Feb 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.