Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zlib][CRC32] Trim 'start' value to 32-bit for negative long integers #5350

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@prashantvithani
Copy link
Contributor

prashantvithani commented Oct 8, 2018

As discussed in #5290 (comment), The while loop in gf2_matrix_times should terminate after 32 iterations. That means the value of 'start' should be 0 after (start>>32). Trimming the value beyond 32 bits ensures that behavior.

FIX #5290

Trim 'start' value to 32-bit for negative long integers
As discussed in #5290 (comment), The while loop in gf2_matrix_times should terminate after 32 iterations. That means the value of 'start' should be 0 after (start>>32). Trimming the value beyond 32 bits ensures that behavior.

@prashantvithani prashantvithani changed the title Trim 'start' value to 32-bit for negative long integers [CRC32][Zlib] Trim 'start' value to 32-bit for negative long integers Oct 8, 2018

@prashantvithani prashantvithani changed the title [CRC32][Zlib] Trim 'start' value to 32-bit for negative long integers [Zlib][CRC32] Trim 'start' value to 32-bit for negative long integers Oct 8, 2018

@headius

This comment has been minimized.

Copy link
Member

headius commented Oct 9, 2018

Nice, thanks! I was hoping it would be something simple like this.

@headius headius added this to the JRuby 9.2.1.0 milestone Oct 9, 2018

@headius headius merged commit 1d15ed5 into jruby:master Oct 9, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@prashantvithani

This comment has been minimized.

Copy link
Contributor Author

prashantvithani commented Oct 11, 2018

@headius Thanks for merging this! I was wondering if you could you tell when this change would be released? This was kind of blocker for us to migrate to JRuby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.