Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Psych 3.0.3.pre2. See ruby/psych#352. #5351

Merged
merged 7 commits into from Oct 22, 2018

Conversation

Projects
None yet
2 participants
@headius
Copy link
Member

headius commented Oct 9, 2018

Testing new Psych release. Roll forward to 3.0.3 final before merging.

@headius headius added this to the JRuby 9.2.1.0 milestone Oct 9, 2018

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Oct 9, 2018

Ping ruby/psych#352 and @hsbt.

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Oct 11, 2018

I pushed a fix to psych for ruby/psych#352 and requested new preview release; when that has been tested here we can move forward with a final.

@hsbt

This comment has been minimized.

Copy link

hsbt commented Oct 12, 2018

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Oct 12, 2018

@hsbt Testing now!

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Oct 12, 2018

@hsbt Are you sure it rebuilt? I'm still getting the same error that should have been fixed by my patch on master. I confirmed it loads properly if I build and install it locally.

@hsbt

This comment has been minimized.

Copy link

hsbt commented Oct 12, 2018

@headius Sorry, I re-used the previous build asset. I upload pre4 binary again. Can you confirm it?

https://rubygems.org/gems/psych/versions/3.0.3.pre4-java

headius added some commits Oct 19, 2018

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Oct 19, 2018

@hsbt It's looking good so far! I have pushed to this PR to let CI run.

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Oct 19, 2018

@hsbt I found another bug with how I mapped flow styles from Psych to SnakeYAML that I fixed in ruby/psych@27232b3. I pushed 3.0.3.pre5-java and it is now testing in CI.

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Oct 19, 2018

@hsbt I believe we can move forward with a full release of 3.0.3 now, as long as it contains all my commits to master. Thanks for your help and patience!

@hsbt

This comment has been minimized.

Copy link

hsbt commented Oct 20, 2018

@headius I released 3.0.3!

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Oct 22, 2018

@hsbt Thank you again for your help!

@headius headius merged commit 7a9faa3 into jruby:master Oct 22, 2018

@headius headius deleted the headius:test-psych-3.0.3 branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.