Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JDK atomic move to more closely emulate POSIX rename. #5356

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
1 participant
@headius
Copy link
Member

commented Oct 11, 2018

Fixes #5318.

Note that this no longer does the explicit file store check,
because that failed in an unrelated way when running under a
FreeBSD jail. Instead this now relies on the Files subsystem of
JDK to percolate out the original error message, which we should
detect properly and turn into EXDEV.

Use JDK atomic move to more closely emulate POSIX rename.
Fixes #5318.

Note that this no longer does the explicit file store check,
because that failed in an unrelated way when running under a
FreeBSD jail. Instead this now relies on the Files subsystem of
JDK to percolate out the original error message, which we should
detect properly and turn into EXDEV.

@headius headius added this to the JRuby 9.2.1.0 milestone Oct 11, 2018

@headius headius merged commit 706bd4e into jruby:master Oct 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@headius headius deleted the headius:atomic_move_for_rename branch Oct 26, 2018

@ahorek ahorek referenced this pull request Nov 6, 2018

Closed

Regression 9.2.1.0 File#mv #5415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.