Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect frozen_string_literal #5357

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
2 participants
@ahorek
Copy link
Contributor

commented Oct 11, 2018

reference
https://bugs.ruby-lang.org/issues/15118

see also

// obj["string"] optimization for Hash

pavel
@headius

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

👍

@headius headius added this to the JRuby 9.2.1.0 milestone Oct 11, 2018

@headius

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

Ignore the test:jruby:aot failure; it is a regression that snuck in with timeout fixes.

@headius headius merged commit 15ae912 into jruby:master Oct 11, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@headius

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

Oh oops...it just occurred to me that "WIP" might mean you have more coming? I kinda got lost in merging today.

@ahorek ahorek changed the title WIP: respect frozen_string_literal respect frozen_string_literal Oct 11, 2018

@ahorek

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

I was just waiting for CI to confirm it won't break anyhing else. Thanks for merging so quickly!

@ahorek ahorek referenced this pull request Oct 12, 2018

Merged

Fix #5357 #5360

headius added a commit that referenced this pull request Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.