Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing coercion case for subtraction from BigDecimal. Fixes #5386. #5391

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

seandmccarthy
Copy link
Contributor

No description provided.

Copy link
Member

@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, please move the test and should be good to go (into 9.2.1)

@@ -772,6 +772,11 @@ def test_sub_with_rational
assert_kind_of(BigDecimal, BigDecimal("3") - 1.quo(3))
end

def test_sub_with_coercion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the MRI tests get imported from MRI ... this change might get lost later.
it would be better to move this under test/jruby/ (or write a ruby spec).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, thanks for the heads up. I'll move the the test.

@kares kares added this to the JRuby 9.2.1.0 milestone Oct 31, 2018
@kares kares merged commit f7ef0fb into jruby:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants