Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing coercion case for subtraction from BigDecimal. Fixes #5386. #5391

merged 2 commits into from Oct 31, 2018


Copy link

@seandmccarthy seandmccarthy commented Oct 31, 2018

No description provided.

Copy link

@kares kares left a comment

good job, please move the test and should be good to go (into 9.2.1)

@@ -772,6 +772,11 @@ def test_sub_with_rational
assert_kind_of(BigDecimal, BigDecimal("3") - 1.quo(3))

def test_sub_with_coercion

This comment has been minimized.


kares Oct 31, 2018

the MRI tests get imported from MRI ... this change might get lost later.
it would be better to move this under test/jruby/ (or write a ruby spec).

This comment has been minimized.


seandmccarthy Oct 31, 2018
Author Contributor

Ah cool, thanks for the heads up. I'll move the the test.

@kares kares added this to the JRuby milestone Oct 31, 2018
@kares kares merged commit f7ef0fb into jruby:master Oct 31, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants