Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[ji] make inspect on Java proxies work" #5397

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
2 participants
@headius
Copy link
Member

headius commented Oct 31, 2018

The first commit from this PR appears to be the cause of #5395. Because I believe that commit is crucial to the rest of the PR working properly, I'm spinning up a revert PR so we can discuss this.

The only answer I have right now is to revert this. I'm not sure I see how the monkey-patching shown in #5395 will be possible if we change how methods get bound.

@headius headius added this to the JRuby 9.2.1.0 milestone Oct 31, 2018

@headius headius requested review from enebo and kares Oct 31, 2018

@kares

This comment has been minimized.

Copy link
Member

kares commented Nov 1, 2018

good find - makes sense to revert if 9.2.1 is so close and there's no clear resolution

@headius headius merged commit 3e1e766 into master Nov 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@headius headius deleted the revert-5219-ji-inspect branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.