Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use the UTC formatter if time was not specified as relative. #5402

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
2 participants
@headius
Copy link
Member

headius commented Nov 1, 2018

Fixes #5400.

As far as I could tell, in MRI they have a tri-state flag on RTIME:

  • gmt = 0 means non-UTC format
  • gmt = 1 means UTC format
  • gmt = 2 means relative offset, non-UTC format

We have a single isTzRelative flag that, when combined with the actual zone of the DateTime object, can be used to emulate these three states.

@enebo enebo added this to the JRuby 9.2.1.0 milestone Nov 2, 2018

@enebo enebo merged commit 492ea4d into jruby:master Nov 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.