Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
remove getClass from RubyRegexp #5410
Nov 16, 2018
1 check passed
I think these are null checks. It's a pattern I don't agree with, but
I went ahead with the asserts in 84be473.
@ahorek It may be possible to prove these never receive null but I figured we should put the checks back for now anyway. Obviously these have not been firing for normal JRuby users or we'd have seen the NPE bug reports. Asserts add to bytecode size but will not execute normally, so this seems ok. And these do need to be be non-null, so having the asserts is appropriate.