Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overflow in #i_gcd #5443

Merged
merged 1 commit into from Nov 13, 2018
Merged

fix overflow in #i_gcd #5443

merged 1 commit into from Nov 13, 2018

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Nov 12, 2018

Long.numberOfTrailingZeros returns an integer
long result = 1 << int;

fixes

-9223372036854775808.gcd(0)

returns 1 but it should return 9223372036854775808

@ahorek ahorek force-pushed the ahorek:gcd_overflow branch from 4ba8fc9 to 5c3c90c Nov 12, 2018
@kares kares merged commit 1c8ac39 into jruby:master Nov 13, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kares kares added this to the JRuby 9.2.4.0 milestone Nov 13, 2018
@enebo enebo modified the milestones: JRuby 9.2.4.0, JRuby 9.2.5.0 Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants