Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempfile.open should have arity 3, to allow IO options through. #5458

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
1 participant
@headius
Copy link
Member

headius commented Nov 20, 2018

Fixes #5456.

In #5456, @erikogan shows that his example code worked in 9.1.17.0, but I could find no changes to Tempfile during the past 9 months that would explain the regression.

@headius headius added this to the JRuby 9.2.5.0 milestone Nov 20, 2018

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Nov 20, 2018

Bisecting was inconclusive 👎

@headius headius merged commit 2a8d255 into jruby:master Nov 20, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@headius headius deleted the headius:tempfile_open_arity_3 branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.