Remove unused call to `String#replaceAll()`. #546

Merged
merged 1 commit into from Feb 26, 2013

Projects

None yet

3 participants

@pmahoney
Contributor

Not sure this replaceAll should be used, or if it's just a stray.

@enebo
Member
enebo commented Feb 25, 2013

Wow entertaining. We must be too used to Ruby Strings :)

The real question I have about this is why this was there in the first place. We clearly have no coverage for this code but should it be fixed or removed?

@headius
Member
headius commented Feb 26, 2013

Yeah, this line obviously does nothing. I'm looking to see whether its intended purpose is needed, but removing it is not a problem.

@headius headius merged commit 0001ac3 into jruby:master Feb 26, 2013

1 check passed

default The Travis build passed
Details
@pmahoney pmahoney deleted the pmahoney:string-no-op branch Feb 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment