Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove unused call to `String#replaceAll()`. #546

Merged
merged 1 commit into from

3 participants

@pmahoney

Not sure this replaceAll should be used, or if it's just a stray.

@enebo
Owner

Wow entertaining. We must be too used to Ruby Strings :)

The real question I have about this is why this was there in the first place. We clearly have no coverage for this code but should it be fixed or removed?

@headius
Owner

Yeah, this line obviously does nothing. I'm looking to see whether its intended purpose is needed, but removing it is not a problem.

@headius headius merged commit 0001ac3 into from
@pmahoney pmahoney deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 24, 2013
  1. @pmahoney
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 2 deletions.
  1. +0 −2  src/org/jruby/internal/runtime/methods/DefaultMethod.java
View
2  src/org/jruby/internal/runtime/methods/DefaultMethod.java
@@ -142,8 +142,6 @@ private DynamicMethod tryJitReturnMethod(ThreadContext context) {
// use the class name
className = implementationClass.getName();
}
- // replace double-colons with dots, to match Java
- className.replaceAll("::", ".");
context.runtime.getJITCompiler().tryJIT(this, context, className, name);
return box.actualMethod;
}
Something went wrong with that request. Please try again.