Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add java 10, 11 opcodes #5462

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
4 participants
@ahorek
Copy link
Contributor

ahorek commented Nov 21, 2018

fixes warnings
WARNING: Illegal reflective access by org.jruby.util.SecurityHelper to field java.lang.reflect.Field.modifiers
WARNING: Please consider reporting this to the maintainers of org.jruby.util.SecurityHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

pavel
@kares

This comment has been minimized.

Copy link
Member

kares commented Nov 21, 2018

oh really, does it fix those warnings, like all of them? now, I am a bit confused, do you know why is that?
... anyway, this makes sense either way, I might have left that TODO there myself :)

@kares kares added this to the JRuby 9.2.5.0 milestone Nov 21, 2018

@ahorek

This comment has been minimized.

Copy link
Contributor Author

ahorek commented Nov 21, 2018

I know, you changed the default version to 1.8 in 1b10d61#diff-f1a3566fb02f3f96df7df320d1a2a669

this condition now fails on java 10, 11

@kares

This comment has been minimized.

Copy link
Member

kares commented Nov 21, 2018

right, that makes sense - guess its one warning at a time than :)
but there's a but which we might not need to care about atm, still for the record:

-Xbytecode.version should be used to specify version of generated byte-code.

... so maybe the SecurityHelper should not rely on that, we shall audit afterwards

@enebo enebo modified the milestones: JRuby 9.2.5.0, JRuby 9.2.6.0 Dec 6, 2018

@headius headius merged commit f8899fc into jruby:master Dec 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@headius

This comment has been minimized.

Copy link
Member

headius commented Dec 13, 2018

Thank you!

kares added a commit to kares/jruby that referenced this pull request Dec 27, 2018

do not use JAVA_VERSION for runtime version check
this constant is changeable using -Xbytecode.version=9
so its poorly named, use safer detection of Java 9+

follow-up on jrubyGH-5462
(merged from f8899fc)

kares added a commit that referenced this pull request Dec 27, 2018

do not use JAVA_VERSION for runtime version check
this constant is changeable using -Xbytecode.version=9
so its poorly named, use safer detection of Java 9+

follow-up on GH-5462
(merged from f8899fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.