Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5288] Overwrite parent class with module wrapper #5487

Merged
merged 1 commit into from Dec 1, 2018

Conversation

Projects
None yet
2 participants
@alexis779
Copy link
Contributor

commented Dec 1, 2018

Fixes Module#refine regression when using Module#include to inject functions.

Compare latest refinement commit with CRuby rb_using_refinement.

RubyModule#setSuperClass call was dropped. We add it back again.

@kares

This comment has been minimized.

Copy link
Member

commented Dec 1, 2018

nice work @alexis779, thanks!

@kares kares added this to the JRuby 9.2.5.0 milestone Dec 1, 2018

@kares kares merged commit 1bf79da into jruby:master Dec 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.