Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved error message for "wrong number of arguments" #5491

Merged
merged 2 commits into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@ahorek
Copy link
Contributor

ahorek commented Dec 3, 2018

see #5475

@ahorek ahorek force-pushed the ahorek:args branch 2 times, most recently from 7baf23b to 4712f3a Dec 3, 2018

@headius

This comment has been minimized.

Copy link
Member

headius commented Dec 3, 2018

This should be squashed when merged. Let us know when you're satisfied 😀

@ahorek ahorek force-pushed the ahorek:args branch from e2e8e56 to c527868 Dec 3, 2018

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Dec 3, 2018

@ahorek travis is pretty unhappy with some Enumerator arity errors. Perhaps something in this PR changed some arity checking?

@ahorek

This comment has been minimized.

Copy link
Contributor Author

ahorek commented Dec 3, 2018

yeah, there're still some cases that don't work as expected, I'll let you know when it's ready

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Dec 3, 2018

@ahorek ok. Thanks for fixing this... It has been an annoyance that the format was old

@ahorek ahorek force-pushed the ahorek:args branch 2 times, most recently from 602878a to 7ae5d71 Dec 3, 2018

@ahorek ahorek force-pushed the ahorek:args branch from 7ae5d71 to f18a5ab Dec 3, 2018

@ahorek ahorek changed the title WIP: improved error message for "wrong number of arguments" improved error message for "wrong number of arguments" Dec 3, 2018

@ahorek

This comment has been minimized.

Copy link
Contributor Author

ahorek commented Dec 3, 2018

@enebo @headius ready for review!

@enebo enebo added this to the JRuby 9.2.5.0 milestone Dec 3, 2018

@enebo enebo merged commit 05d0d93 into jruby:master Dec 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@enebo

This comment has been minimized.

Copy link
Member

enebo commented Dec 3, 2018

@ahorek looks pretty straight-forward...just merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.