Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failed tag for Array#to_h MRI tests #5495

merged 1 commit into from Dec 3, 2018


Copy link

@nomadium nomadium commented Dec 3, 2018

I couldn't find anything wrong with those assertions, they seem to be passing since a long time ago.

def test_to_h
kvp =
def kvp.to_ary
[:obtained, :via_to_ary]
array = [
[:key, :value],
assert_equal({key: :value, obtained: :via_to_ary}, array.to_h)
e = assert_raise(TypeError) {
[[:first_one, :ok], :not_ok].to_h
assert_equal "wrong element type Symbol at 1 (expected array)", e.message
array = [eval("class C\u{1f5ff}; self; end").new]
assert_raise_with_message(TypeError, /C\u{1f5ff}/) {array.to_h}
e = assert_raise(ArgumentError) {
[[:first_one, :ok], [1, 2], [:not_ok]].to_h
assert_equal "wrong array length at 2 (expected 2, was 1)", e.message

@enebo enebo added this to the JRuby milestone Dec 3, 2018
@enebo enebo merged commit 2f0a6d2 into jruby:master Dec 3, 2018
@nomadium nomadium deleted the untag-array-to_h-mri-test branch December 4, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants