Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sub-millisecond datetime difference handling #5516

Merged
merged 1 commit into from Dec 13, 2018

Conversation

@ikaronen-relex
Copy link
Contributor

@ikaronen-relex ikaronen-relex commented Dec 13, 2018

This patch fixes issue #5493 and adds the test case from the report as a new spec. It also fixes the existing DateTime add/subtract specs to actually use sub-millisecond differences like their descriptions say.

@headius headius requested a review from kares Dec 13, 2018
@headius headius added this to the JRuby 9.2.6.0 milestone Dec 13, 2018
kares
kares approved these changes Dec 13, 2018
Copy link
Member

@kares kares left a comment

seem reasonable, wonder why I ended up not looking here the last time I tried ...

@kares kares merged commit 9eedcdd into jruby:master Dec 13, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants