Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate ivar and const symbols from Java before adding to table. #5531

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
1 participant
@headius
Copy link
Member

commented Dec 18, 2018

This uses the logic from #5523 to do the symbol validation within the ID logic. This allows it to raise for both existing symbols and new symbols, but new symbols are neither inserted into the table nor hard-referenced if an error is raised.

Fixes #5169.

@headius headius requested a review from enebo Dec 18, 2018

@headius headius added this to the JRuby 9.2.6.0 milestone Dec 18, 2018

@headius headius merged commit 2c99771 into jruby:master Dec 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@headius headius deleted the headius:error_before_symbol_store branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.