Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a proper annotation parameter for DynamicMethod.Version #5548

Merged
merged 1 commit into from Jan 4, 2019

Conversation

@donv
Copy link
Member

@donv donv commented Jan 3, 2019

This parameter is set to 0 in
InvocationMethodFactory.createJavaMethodCtor and in the precompiled
INVOKER classes. This works somehow on the JVM, but fails in the
DalvikVM.

Source for defining annotation parameters:
https://docs.oracle.com/javase/tutorial/java/annotations/declaring.html

@donv donv requested a review from headius Jan 3, 2019
@donv donv self-assigned this Jan 3, 2019
This parameter is set to 0 in
InvocationMethodFactory.createJavaMethodCtor and in the precompiled
INVOKER classes.  This works somehow on the JVM, but fails in the
DalvikVM.

Source for defining annotation parameters:
https://docs.oracle.com/javase/tutorial/java/annotations/declaring.html
@donv donv force-pushed the fix_dynamic_method_version_annotation_parameter branch from aade01b to 316a021 Jan 3, 2019
@headius headius added this to the JRuby 9.2.6.0 milestone Jan 4, 2019
@headius
Copy link
Member

@headius headius commented Jan 4, 2019

Super weird. Merging.

@headius headius merged commit 562e1f9 into master Jan 4, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
@donv donv deleted the fix_dynamic_method_version_annotation_parameter branch Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants