Define a proper annotation parameter for DynamicMethod.Version #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter is set to 0 in InvocationMethodFactory.createJavaMethodCtor and in the precompiled INVOKER classes. This works somehow on the JVM, but fails in the DalvikVM. Source for defining annotation parameters: https://docs.oracle.com/javase/tutorial/java/annotations/declaring.html
donv
force-pushed
the
fix_dynamic_method_version_annotation_parameter
branch
from
aade01b
to
316a021
Compare
|
Super weird. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is set to 0 in
InvocationMethodFactory.createJavaMethodCtor and in the precompiled
INVOKER classes. This works somehow on the JVM, but fails in the
DalvikVM.
Source for defining annotation parameters:
https://docs.oracle.com/javase/tutorial/java/annotations/declaring.html