Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Thread#status should reflect exited exception #5554

Merged
merged 3 commits into from Jan 21, 2019

Conversation

Projects
None yet
1 participant
@kares
Copy link
Member

commented Jan 11, 2019

... always returning nil (instead of false)
+ and handle join(arg) to_f coercion like MRI

closes GH-5312

kares added some commits Dec 29, 2018

[fix] Thread#status should reflect exited exception
a non-alive thread should check existing exception

backing Java thread might still be 'alive' after its disposed
(see RubyRunnable) such state shall not avoid the exception check
since the RubyThread is already effective dead (unregistered etc)

resolves GH-5312
this can alternatively be accomplished using the disposed flag
[test] status after thread exception is nil
(a better TestThread#test_status_and_stop_p from MRI suite)

@kares kares merged commit 5cce048 into master Jan 21, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@kares kares added this to the JRuby 9.2.6.0 milestone Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.