Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix float formating regression (half-even rounding) #5580

Merged
merged 3 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@kares
Copy link
Member

kares commented Jan 29, 2019

resolves #5556

relates to introducing half even rounding (as identified in the issue): bc2ba39
... which need some special care to only apply if there's no tail left

credits to @lassiter for identifying the 'breaking' commit + putting up tests

lassiter and others added some commits Jan 23, 2019

[fix] only round half-to-even when no tail left
e.g.  0.25 -> 0.2   0.2500 -> 0.2   0.2501 -> 0.3

resolves GH-5556
[test] few round half-to-even asserts for sprintf
since this seems to be a failure point for JRuby (GH-5556)

@kares kares added this to the JRuby 9.2.6.0 milestone Jan 29, 2019

@enebo enebo merged commit ae888ff into jruby:master Jan 29, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@kares kares referenced this pull request Mar 7, 2019

Closed

Sprintf doesn't round #5643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.