Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] interpret today TZ-relative but use GJ chrono #5581

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
2 participants
@kares
Copy link
Member

kares commented Jan 29, 2019

this should match the logic that was in place in 9.1.17.0
... expected to, finally and properly, resolve GH-5418
(reverts previous attempt #5560 - which reverted d6a93ce)

@enebo or @headius when merging please run test:jruby and test:mri:core on the branch
since CI is UTC - pretty confident it should be all good but just to double check.

[fix] interpret today TZ-relative but use GJ chrono
this should match the logic that was in place in 9.1.17.0
expected to, finally and properly, resolve GH-5418

@kares kares added this to the JRuby 9.2.6.0 milestone Jan 29, 2019

@enebo enebo merged commit 8f0ada6 into jruby:master Jan 29, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@enebo

This comment has been minimized.

Copy link
Member

enebo commented Jan 29, 2019

@kares ran locally and both those passes. Thanks for the extra efforts today. I will start examining if we are 9.2.6.0-ready in the morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.