Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time: fix localtime(), getlocal(), parse() for TZ offset #5583

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@dr-itz
Copy link
Contributor

dr-itz commented Jan 30, 2019

When a time is parsed with a TZ offset, t.zone returned an empty
string instead of nil like MRI. This in turn breaks ActiveSupport
Time.change() which then constructs new time values with the wrong
zone, ignoring the offset.

See jruby/activerecord-jdbc-adapter#980

Time: fix localtime(), getlocal(), parse() for TZ offset
When a time is parsed with a TZ offset, t.zone returned an empty
string instead of nil like MRI. This in turn breaks ActiveSupport
Time.change() which then constructs new time values with the wrong
zone, ignoring the offset.

See jruby/activerecord-jdbc-adapter#980

@dr-itz dr-itz referenced this pull request Jan 30, 2019

Open

Rails 6 support #980

@enebo enebo added this to the JRuby 9.2.6.0 milestone Jan 30, 2019

@enebo enebo merged commit 83cba34 into jruby:master Jan 30, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@enebo

This comment has been minimized.

Copy link
Member

enebo commented Jan 30, 2019

@dr-itz I don't get what is happening with that ci run but it looks unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.