Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time: minimal fix for Rails Time.change() problem #5587

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@dr-itz
Copy link
Contributor

dr-itz commented Jan 31, 2019

When there is no timezone (empty string), return nil like MRI.

See also jruby/activerecord-jdbc-adapter#980

Time: minimal fix for Rails Time.change() problem
When there is no timezone (empty string), return nil like MRI.
@kares

This comment has been minimized.

Copy link
Member

kares commented Feb 1, 2019

nice, let's try to squeeze this one into 9.2.6 😉 // cc @enebo

@kares kares added this to the JRuby 9.2.6.0 milestone Feb 1, 2019

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Feb 1, 2019

@dr-itz have you ever contributed to ruby/spec before? because this one is screaming for a spec...

@enebo enebo merged commit 0f18759 into jruby:master Feb 1, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@dr-itz

This comment has been minimized.

Copy link
Contributor Author

dr-itz commented Feb 3, 2019

@enebo no, but I'll look into it..there's more than one spec needed here...but it'll probably be not before next weekend or so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.