Isolate debug specs and run fast suite without --debug #5636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headius
force-pushed
the
isolate_debug_specs
branch
5 times, most recently
from
864f170
to
4b3220c
Compare
This allows us to drop --debug for the bulk of specs, speeding spec runs and testing the way most people will run JRuby.
headius
force-pushed
the
isolate_debug_specs
branch
2 times, most recently
from
91fc581
to
f7eee29
Compare
headius
force-pushed
the
isolate_debug_specs
branch
from
f7eee29
to
e648d67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm moving any specs that require --debug to the "slow" suite and enabling that suite in CI. This should speed up the main "fast" suite and allow us to untag some specs that are broken by --debug.