Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run deploy against actual pushes to our repo #5645

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@headius
Copy link
Member

headius commented Mar 7, 2019

It was also running for PRs against the master and maintenance
branches.

@headius headius added this to the JRuby 9.2.7.0 milestone Mar 7, 2019

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Mar 7, 2019

This can be merged if the build does not have the "deploy" stage while still in PR form.

@kares

This comment has been minimized.

Copy link
Member

kares commented Mar 11, 2019

wouldn't the artifact deployment push become problematic when doing a release ?

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Mar 13, 2019

@kares I believe it would just push to the snapshot repo as normal with a release version. I'm not sure if that would be a problem... @mkristian may know more. It should be possible to filter the deploy stage to only try to deploy when version ends in SNAPSHOT.

Only run deploy against actual pushes to our repo.
It was also running for PRs against the master and maintenance
branches.

@headius headius force-pushed the headius:only_deploy_pushes branch from 1e239a2 to 394d823 Mar 13, 2019

@headius

This comment has been minimized.

Copy link
Member Author

headius commented Mar 13, 2019

Latest tweak does not have the "deploy" stage on PRs, so I'm merging it.

@headius headius merged commit 7dd061d into jruby:master Mar 13, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@headius headius deleted the headius:only_deploy_pushes branch Mar 13, 2019

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Mar 20, 2019

@headius @kares deploy with SNAPSHOT in version will use snapshot repo and without SNAPSHOT it will use staging repo. you will see it on sonatype webinterface how deployed it and when. it is still a human which closes the release and pushes it to maven-central. so all good IMO

@kares

This comment has been minimized.

Copy link
Member

kares commented Mar 20, 2019

@mkristian agreed, still would have been confusing if you as a release manager would see two deployed artifacts in staging - one from CI and another from you running deploy.

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Mar 21, 2019

@kares agree also about the confusing bit. let me see if we can deploy on snapshots, not sure yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.