Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use close_on_exec method instead of using fcntl calls for pty. Fixes #5663 #5677

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
4 participants
@byteit101
Copy link
Member

byteit101 commented Apr 4, 2019

Fix as suggested in #5663. Provides same behavior as MRI now.

Additionally, I ran this test: jruby -r ./test/mri/lib/envutil.rb test/mri/test_pty.rb and it passed. I wasn't sure if I needed to to anything else, or why https://github.com/jruby/jruby/blob/master/test/mri/excludes/TestPTY.rb suggests that it should fail.

This also doesn't address the opposite behavior of the nonblock flag as I noted in #5663

Resolves #5663

@kares kares added this to the JRuby 9.2.7.0 milestone Apr 4, 2019

@enebo enebo merged commit ec40f37 into jruby:master Apr 5, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@headius

This comment has been minimized.

Copy link
Member

headius commented Apr 6, 2019

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.