Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that lazy enumerator doesn't pre-evaluate #5697

Merged
merged 1 commit into from Apr 14, 2019

Conversation

@twalpole
Copy link
Contributor

@twalpole twalpole commented Apr 14, 2019

@headius These are some simple tests for the lazy enumerator issue you pushed patches for recently. Unfortunately I haven't been able to get the build environment set up correctly to run them myself and see why they're failing (I keep getting a (OpenSSL::X509::StoreError) setting default path failed: No password supplied for PKCS#12 KeyStore error when attempting mvn -Pbootstrap)

@headius headius added this to the JRuby 9.2.8.0 milestone Apr 14, 2019
@headius
Copy link
Member

@headius headius commented Apr 14, 2019

@kares What was the solution for that "No password supplied" SSL thing?

@twalpole The specs look great and appear to have passed (even though another spec failed) so I'll merge. Thank you!

Loading

@headius headius merged commit 76b490b into jruby:master Apr 14, 2019
1 of 2 checks passed
Loading
@kares
Copy link
Member

@kares kares commented Apr 17, 2019

these specs weren't finished, they even fail on MRI 2.5 e.g.

Enumerator::Lazy#select doesn't pre-evaluate the next element ERROR
NoMethodError: undefined method `change' for #<MSpecEnv:0x000055a199c22230>
/home/kares/workspace/oss/jruby/spec/ruby/core/enumerator/lazy/select_spec.rb:18:in `block (2 levels) in <top (required)>'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:104:in `instance_eval'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:104:in `protect'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/context.rb:179:in `block in protect'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/context.rb:179:in `each'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/context.rb:179:in `all?'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/context.rb:179:in `protect'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/context.rb:215:in `block (2 levels) in process'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:274:in `block in repeat'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:273:in `times'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:273:in `repeat'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/context.rb:207:in `block in process'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/context.rb:206:in `each'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/context.rb:206:in `process'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:48:in `describe'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/object.rb:11:in `describe'
/home/kares/workspace/oss/jruby/spec/ruby/core/enumerator/lazy/select_spec.rb:6:in `<top (required)>'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:88:in `load'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:88:in `block (2 levels) in files'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:104:in `instance_eval'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:104:in `protect'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:88:in `block in files'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:79:in `each'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:79:in `each_file'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:84:in `files'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/runner/mspec.rb:56:in `process'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/commands/mspec-ci.rb:75:in `run'
/home/kares/workspace/oss/jruby/spec/mspec/lib/mspec/utils/script.rb:276:in `main'
/home/kares/workspace/oss/jruby/spec/mspec/bin/mspec-ci:7:in `<main>'

Loading

@kares kares added the tests label Apr 17, 2019
eregon added a commit to ruby/spec that referenced this issue Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants