Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ji] support java.math.BigDecimal#to_d #5701

Merged
merged 1 commit into from Apr 20, 2019

Conversation

@kares
Copy link
Member

commented Apr 18, 2019

to_d is a convention used by Ruby's BigDecimal (from bigdecimal/util.rb)

also explicitly re-def inherited Java Number extensions

NOTE: a reminder that this won't have negative impact on loading, since Java extension are lazy

@kares kares added this to the JRuby 9.2.8.0 milestone Apr 18, 2019

@kares kares force-pushed the ji-bigdecimal branch from 12e20d9 to 6f5fda0 Apr 18, 2019

[ji] support java.math.BigDecimal#to_d
`to_d` is a convention used by Ruby's BigDecimal
(from bigdecimal/util.rb)

also explicitly re-def inherited Java Number extensions

@kares kares merged commit 1679826 into master Apr 20, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
jruby.jruby Build #20190418.4 succeeded
Details

@kares kares deleted the ji-bigdecimal branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.